Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dates browser-localized #167

Closed
wants to merge 1 commit into from
Closed

Show dates browser-localized #167

wants to merge 1 commit into from

Conversation

Max13
Copy link
Contributor

@Max13 Max13 commented Jun 6, 2018

Changed moment's format to short format, which is correctly shown depending on browser's locale

@taylorotwell
Copy link
Member

@themsaid is this a good idea?

@Max13
Copy link
Contributor Author

Max13 commented Jun 7, 2018

@taylorotwell I just want to add that short formats (LL instead of MMMM Do, YYYY for instance) produce the exact same output. So currently, there is no downside about it. The benefit is, moment has already localized these pre-defined formats.

@themsaid
Copy link
Member

themsaid commented Jun 7, 2018

It could be considered a breaking change since dates will get displayed in the localized form, now it'll always be in English.

Can consider this in a future update.

@themsaid themsaid closed this Jun 7, 2018
@Max13
Copy link
Contributor Author

Max13 commented Jun 7, 2018

@themsaid Actually, only resources/assets/js/spark-bootstrap.js is breaking localization. The other files will still show the dates as they currently are.

I may sound picky, but I think the more we can pull without breaking, the less there will be changes between current version and updates. I have modified a lot of files to suits my needs (which could be general needs, like l10n), but for each new patch, I have to review all diffs.

I know the best is to stick to a working version, but I haven't started to write my project yet, so I'm updating even the smallest patch ;)

@themsaid
Copy link
Member

themsaid commented Jun 7, 2018

We have to be very careful with Spark changes in order not to break people production apps, that's why if the change isn't fixing anything we tend to keep it for a point release where we can announce the changes in a more clear way.

Will keep this PR in my trello board for when the time comes :)

@Max13
Copy link
Contributor Author

Max13 commented Jun 7, 2018

I agree with you on the process of not breaking changes. I was just saying that some changes I did were not breaking anything.

Anyway, I hope it will be for sooooon ;)

I'll be more careful about my PR next time. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants