Makes SparkForm internal attributes non-enumerable #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when looping SparkForm's properties or submitting forms cause `errors`, `busy` and `successful` internal properties to be shown/submitted as well, potentially overriding a form's input.
|
Can you please explain in more detail what this PR is trying to solve? I don't seem to get the problem? Can you please share code? |
|
Ping @Max13 |
|
When a I think these keys are not supposed to be sent anyway, are they? For instance, a form containing a Do you still need code? |
|
Maybe you could just rename your form variables to something else? |
|
@taylorotwell Of course I and everybody else can, but I just thought that it would be a good idea to make them non enumerable to avoid this behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when looping SparkForm's properties or submitting forms cause
errors,busyandsuccessfulinternal properties to be shown/submitted as well, potentially overriding a form's input.These changes shouldn't break anything.