Update UpdateContactInformationOnStripe.php

[vincentvankekerix]

When Team Billing is being used, the 'stripe_id' database field stays empty for the User Model. When User changes their email address, the listener will not work for changing the email address for the corresponding customer in Stripe, since there is no stripe_id stored in the database. This updated listener will look for the stripe_id at the currentTeam, in order to find the matching customer in Stripe, so that email addresses can be updated.

[taylorotwell]

Please follow the code formatting standards used by the rest of the library.

[vincentvankekerix]

Do you mean following the PSR-2 standard, or do you mean something else?

[rickmacgillis]

I haven't looked into this too much yet, but I've been wondering is using the current team is really the best approach. IIRC Spark allows each TEAM to be billed when using team billing instead of the user. So, updating the current team when a user updates their info might not update the correct team.

[vincentvankekerix]

You're very right: besides that, I just realize that when a team member updates their email address (instead of the team owner), the email address of the team member gets pushed to Stripe, which is not the result we want. I'm gonna do some refactoring here!

[rickmacgillis]

@vincentvankekerix - Awesome! I appreciate your work on this alleged issue.

[vincentvankekerix]

@rickmacgillis You're welcome! Just did some testing, I think the new version below should solve both issues. What do you think?

public function handle($event)
{
    if ($event->user->hasBillingProvider()) {
        $customer = $event->user->asStripeCustomer();

        $customer->email = $event->user->email;

        $customer->save();
    }
    
    foreach ($event->user->ownedTeams as $team) {
        if ($team->hasBillingProvider()) {
            $customer = $team->asStripeCustomer();

            $customer->email = $event->user->email;

            $customer->save();
        }
    }
}

[rickmacgillis]

@vincentvankekerix - It looks more promising. How does it function with unit or feature tests?