handle 'chart' and 'mousetrap' dependencies through package.json #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than linking to the CDNs, we'll handle these dependencies with our package manager. there is a *minimal* hit in filesize, but this gives us the benefit of keeping external dependencies up to date through one mechanism. I think there's potential to take advantage of these libraries on other pages as well. I know, personally, mousetrap is something I install in every project.
|
You can do that in your own project if you want, this is a breaking change for no real gain. |
|
For what it worths, I personally see the current state (hard linking these 2 libs) as an inconsistency. I would have preferred them to be handled by package.json, which would allow the few of us not being 100% connected all the time, to still be able to use the functionalities depending on these libs. While not bringing any major downside to others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than linking to the CDNs, we'll handle these dependencies with our package manager. there is a minimal hit in filesize, but this gives us the benefit of keeping external dependencies up to date through one mechanism.
I think there's potential to take advantage of these libraries on other pages as well. I know, personally, mousetrap is something I install in every project.