Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update var to let #336

Closed
wants to merge 1 commit into from
Closed

Update var to let #336

wants to merge 1 commit into from

Conversation

azimidev
Copy link

@azimidev azimidev commented Jun 6, 2019

I thought it's a good idea to update var to let. I don't know if it's been done before in any PR and closed, but feel free to accept or reject. I'll try my best to make better PR every time. 🏆

@SanderMuller
Copy link

Why just use let and not use const where possible?

@azimidev
Copy link
Author

azimidev commented Jun 6, 2019

@SanderMuller I was gonna use const I'm not sure if they like it.

some of those

var self = this;

are unnecessary if they use short arrow functions for instance.

@themsaid
Copy link
Member

themsaid commented Jun 7, 2019

Hey, thanks for the PR but var is fine :)

@themsaid themsaid closed this Jun 7, 2019
@azimidev
Copy link
Author

azimidev commented Jun 7, 2019

No worries mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants