Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I just change the css file to make the page looks better. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

I just change the css file to make the page looks better. #12

wants to merge 1 commit into from

Conversation

boyongjiong
Copy link

I'm confused that when I use make to build loupe.bundle.css, some css just lost. Just as this picture shows:
image

I wonder wether there are any other settings to be done?

As below shows the website after my work:
image

@nyedidikeke
Copy link

Great @boyongjiong.

@yeshiqing
Copy link

Could anyone update it to the server please:~)

grubnubble
grubnubble reviewed Jul 12, 2018
View reviewed changes
Copy link

@grubnubble grubnubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to include npm-debug.log or loupe.bundle.css. Shouldn't we add the bundle files to the .gitignore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubnubble grubnubble grubnubble left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boyongjiong @nyedidikeke @yeshiqing @grubnubble