Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagsupport #1680

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Tagsupport #1680

merged 6 commits into from
Feb 27, 2025

Conversation

FrankMittelbach
Copy link
Member

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Under development
  • Ready to merge

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added -- tested by the code
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

davidcarlisle
davidcarlisle approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@davidcarlisle davidcarlisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, a couple of trivial doc comments

mbertucci47
mbertucci47 reviewed Feb 26, 2025
View reviewed changes
mbertucci47
mbertucci47 reviewed Feb 26, 2025
View reviewed changes
u-fischer
u-fischer approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@u-fischer u-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only two small comments ...

car222222
car222222 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few queries, etc.

@FrankMittelbach FrankMittelbach merged commit 613f4ac into develop Feb 27, 2025
86 checks passed
@FrankMittelbach FrankMittelbach deleted the tagsupport branch February 27, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbertucci47 mbertucci47 mbertucci47 left review comments

@josephwright josephwright josephwright approved these changes

@davidcarlisle davidcarlisle davidcarlisle approved these changes

@u-fischer u-fischer u-fischer approved these changes

@car222222 car222222 car222222 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FrankMittelbach @josephwright @davidcarlisle @u-fischer @car222222 @mbertucci47