Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IMPORTANT) Errors epic: Make provider log optional on Evaluation Results #401

Conversation

andresgutgon
Copy link
Contributor

@andresgutgon andresgutgon commented Oct 11, 2024

What?

This is key in enabling error tracing in our evaluation results and document logs.

Warning

Errors can happen. But we still want to track the story of that failure in the same way. So we want to create failed evaluation results records with an error attached to it.

TODO

  • Make provider_log_id field optional on evaluation_results
  • Make sure evaluation results without provider logs are not used for agreggations
  • Make sure evaluation results without resultable relation are used for aggregations

csansoon
csansoon previously approved these changes Oct 11, 2024
@andresgutgon andresgutgon force-pushed the feature/add-error-reference-to-providerlogs-remove-null-contraint-provider-log-id-evaluation-results branch from 057e888 to e097484 Compare October 11, 2024 08:26
@andresgutgon andresgutgon force-pushed the feature/add-error-reference-to-providerlogs-remove-null-contraint-provider-log-id-evaluation-results branch from e097484 to b2f2b42 Compare October 11, 2024 09:51
@andresgutgon andresgutgon merged commit 26118a2 into main Oct 11, 2024
4 checks passed
@andresgutgon andresgutgon deleted the feature/add-error-reference-to-providerlogs-remove-null-contraint-provider-log-id-evaluation-results branch October 11, 2024 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants