Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional keyword arguments to collection call. #20

Closed
wants to merge 1 commit into from

Conversation

vizcacha
Copy link

I have a use case where I need to send additional parameters for the collection request. This is achieved with a simple modification to the collection method.

I'm not sure if you are looking for help, but I figured I'd send my changes your way just in case.

@lcosmin
Copy link
Owner

lcosmin commented Jan 18, 2016

Any help is welcome 😁 !

In this case, I'd rather add the parameters explicitly (something like: def collection(self, user_name, brief=True, version=True, ...) ) instead of using **kwargs, so that people who aren't familiar with the BGG API can see the parameters in their IDEs.

I'll create an issue and try to implement it over the next days; feel free to send another pull request in the mean while, if you want to, but use the develop branch, not master.

@lcosmin lcosmin closed this Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants