Ensure there is a unit test for every property. #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too long a day at work to think about the big PR, so here's a simple one: ensure that there is a unit test for every property which exists on the
BoardGame
object. This is particularly important if we're going to refactor any of this in the near future :-)Interestingly, this reveals what might actually be a bug: the
BoardGame.users_wanting
,BoardGame.users_wishing
andBoardGame.users_commented
properties are trying to fetch data fromself._data
rather thanself._stats
and always seem to beNone
. If you agree this is a bug, I'll do a separate PR for that.