Set view center and zoom later so we can capture load event #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This covers the same use case as #43, but using the events from leaflet that were already propagated. |
nhnb
added a commit
that referenced
this pull request
Dec 29, 2015
Set view center and zoom later so we can capture load event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass the center and zoom level to the constructor of the map it will fire the 'load' event before it is propagated. By not passing these options and manually setting the view after the event bubbling is in place we can capture the load and viewreset events from outside.
setView is called in constructor:
https://github.com/Leaflet/Leaflet/blob/master/src/map/Map.js#L43
_resetView fires load event:
https://github.com/Leaflet/Leaflet/blob/master/src/map/Map.js#L534