Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement BinaryHeap using Vector #850

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor: implement BinaryHeap using Vector #850

wants to merge 7 commits into from

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Jun 17, 2024 •
edited
Loading

This is a follow-up to #849 which uses #793 to simplify major parts of the code, paving the way toward correctness proofs for BinaryHeap.

@fgdorais fgdorais added the WIP work in progress label Jun 17, 2024
@fgdorais fgdorais force-pushed the update-binaryheap branch 2 times, most recently from 46d62e2 to bc3b9cf Compare June 17, 2024 10:54
@fgdorais fgdorais changed the title feat: implement BinaryHeap using Vector refactor: implement BinaryHeap using Vector Jun 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jun 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jun 18, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Aug 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 1, 2024
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#850
c938a5b
@fgdorais fgdorais added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed WIP work in progress labels Oct 1, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 1, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#850
3bc9fa8
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2024 •
edited
Loading

Mathlib CI status (docs):

@fgdorais fgdorais marked this pull request as ready for review October 1, 2024 06:48
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

Assignees
No one assigned
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. builds-mathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgdorais @leanprover-community-bot @digama0 @leanprover-community-mathlib4-bot