Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some engineering refactors #486

Closed
wants to merge 4 commits into from
Closed

some engineering refactors #486

wants to merge 4 commits into from

Conversation

thxCode
Copy link

@thxCode thxCode commented Nov 28, 2024

This PR is going to refactor/introduce the following changes.

  • .gitignore: ignore cmake-* and .idea dirs.
  • Align the ggml backend (s/CUBLAS/CUDA/g, s/HIPBLAS/HIP/g) and support CANN, MUSA.
  • Extract public utils for reusing sampler_method/scheduler/rng.
  • Support specifying main-gpu at the API level.
  • Migrate sd_type_t to ggml_type.

Copy link
Contributor

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally agree with this stuff. :)

stable-diffusion.h Outdated Show resolved Hide resolved
stable-diffusion.h Outdated Show resolved Hide resolved
upscaler.cpp Outdated Show resolved Hide resolved
@leejet
Copy link
Owner

leejet commented Nov 30, 2024

stable-diffusion.h is a standalone header file and should not depend on ggml.h. When sd.cpp is provided as a third-party library, user only need to use stable-diffusion.h and the corresponding library files.

@thxCode
Copy link
Author

thxCode commented Dec 1, 2024

stable-diffusion.h is a standalone header file and should not depend on ggml.h. When sd.cpp is provided as a third-party library, user only need to use stable-diffusion.h and the corresponding library files.

rebase master and revert the change, PTAL.

@newfla
Copy link
Contributor

newfla commented Dec 1, 2024

Amazing work, the pr fixes broken Rocm and Metal backends 👏

@thxCode thxCode closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants