Skip to content

Commit

Permalink
RDMA/erdma: Replace zero-length arrays with flexible-array members
Browse files Browse the repository at this point in the history
Zero-length arrays are deprecated[1] and we are moving towards
adopting C99 flexible-array members instead. So, replace zero-length
arrays, in a couple of structures, with flex-array members.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [2].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
Link: KSPP#78
Signed-off-by: Gustavo A. R. Silva <[email protected]>
Link: https://lore.kernel.org/r/Y7zCBqwC1LtabRJ9@work
Reviewed-by: Kees Cook <[email protected]>
Acked-by: Cheng Xu <[email protected]>
Signed-off-by: Leon Romanovsky <[email protected]>
  • Loading branch information
GustavoARSilva authored and rleon committed Jan 15, 2023
1 parent 8067fd8 commit ed73a50
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/infiniband/hw/erdma/erdma_hw.h
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ struct erdma_write_sqe {

__le32 rsvd;

struct erdma_sge sgl[0];
struct erdma_sge sgl[];
};

struct erdma_send_sqe {
Expand All @@ -408,7 +408,7 @@ struct erdma_send_sqe {
};

__le32 length;
struct erdma_sge sgl[0];
struct erdma_sge sgl[];
};

struct erdma_readreq_sqe {
Expand Down

0 comments on commit ed73a50

Please sign in to comment.