Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery and main menu compose rewrite #236

Merged
merged 41 commits into from
Feb 12, 2024
Merged

Gallery and main menu compose rewrite #236

merged 41 commits into from
Feb 12, 2024

Conversation

leonlatsch
Copy link
Owner

@leonlatsch leonlatsch commented Dec 11, 2023 •
edited
Loading

Description:

  • Implement new gallery with jetpack compose and material3 components
  • ImageLoading with coil
  • Add bottom menu instead of top menu
  • Starting point for material3 based ui
  • make image viewer work with uuids instead of int ids

Tasks:

  • Build CI Runs
  • Code Analysis up to standards
  • Faded color should stay balck in white mode
  • Replace start destination
  • Import menu on placeholder screen
  • Placeholder screen
  • Fix back navigation

Fixes #160

Base for #41 and #103

leonlatsch added 27 commits April 17, 2023 09:41
@leonlatsch
start rewriting the gallery in compose
6853736
@leonlatsch
add navigation to new gallery
cbf158c
@leonlatsch
update compose to 2023.04.01
84a0850
@leonlatsch
fix placeholder hiding image
5cfb91e
@leonlatsch
Merge branch 'develop' into gallery_rewrite
5ddbaaf
@leonlatsch
Merge branch 'develop' into gallery_rewrite
df435f6
@leonlatsch
try a custom image fetcher
a28f217
@leonlatsch
make rendering thumbnails in compose working
4ff2f62
@leonlatsch
move compose code
5821377
@leonlatsch
inject image loader in viewModel
401d44e
@leonlatsch
extract photo grid
060ed98
@leonlatsch
use ui model for photo tiles
742e812
@leonlatsch
start implementing ui events
c86ab1b
@leonlatsch
formatting
176e1e0
@leonlatsch
change image viewer to work with uuids and not ids to be able to use …
ffae342 
…uuid for referencing in new gallery
@leonlatsch
implemented opening a photo from the new gallery
5b5779b
@leonlatsch
reimplement old gallery ui
165d7bb
@leonlatsch
add fab
4759848
@leonlatsch
implement new gallery ui
818195e
@leonlatsch
add some kind of menu
48c8377
@leonlatsch
only show menu in gallery screen
def96c5
@leonlatsch
make new menu work
290a226
@leonlatsch
implement multi selection
12a7ad0
@leonlatsch
implement export and delete
62d3b8d
@leonlatsch
add confirm dialog
abc4ef6
@leonlatsch
add select all
4aa60e5
@leonlatsch
make grid rtl
b8503b2
@leonlatsch leonlatsch added feature A new feature or a feature request technical Refactoring or other technical issues improvement A general improvement of an existing feature labels Dec 11, 2023
@leonlatsch leonlatsch self-assigned this Dec 11, 2023
@leonlatsch leonlatsch added this to the Material3 Redesign milestone Feb 12, 2024
@leonlatsch leonlatsch marked this pull request as ready for review February 12, 2024 21:31
@leonlatsch leonlatsch changed the title Rewrite Gallery Gallery and main menu compose rewrite Feb 12, 2024
@leonlatsch
Copy link
Owner Author

Followups: #239 #240

@leonlatsch leonlatsch merged commit 907959f into develop Feb 12, 2024
0 of 3 checks passed
@leonlatsch leonlatsch deleted the gallery_rewrite branch February 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leonlatsch leonlatsch

Labels
feature A new feature or a feature request improvement A general improvement of an existing feature technical Refactoring or other technical issues
Projects
No open projects
Photok
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export not working properly
1 participant
@leonlatsch