feat: allow to destructure props #3382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geovie
commented
Dec 18, 2024
| let name = match *typed.pat { | ||
| Pat::Ident(i) => { | ||
| if let Some(name) = &prop_opts.name { | ||
| PatIdent { |
There was a problem hiding this comment.
This also allows to use the new name attribute on props which are not destructured.
That means props can have different names inside the component and outside (builder).
We can also error here if we don't want to allow renaming normal props
geovie
force-pushed
the
feature/destructured-props
branch
from
f5a2632 to
fd6070c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows props to be destructured in the component definition e.g.
for that to work a
nameattribute was introduced which is used to define the name of the prop in the generated builder.