Skip to content

Commit

Permalink
Updating dependancies to coincide with [email protected]
Browse files Browse the repository at this point in the history
Updating dependancies to co-incide with todays release of Next.js 5.

Initial observations are that [email protected] is slightly faster to build for release, and faster in production but is now slower to build/rebuild pages in development - meaning initial page views can be slow, and changes to take to CSS can take longer to take effect.

These changes in performance do not appear to be specific to this project and are a general impact of 5.0 but I’ll see what, if anything, it’s possible to do to improve performance in development mode.

Some examples features, like the CSS/SCSS handling have not changed in this release, even though there are new examples for handling them in Next.js 5, as they way it’s are currently done in this project is superior to some of the offical examples in some repsects - such as avoiding side effects like flashing on page load while CSS loads.

Some other packages are also updated to make all dependancies are up-to-date, including Bootstrap 4 Beta to the Bootstrap 4.0 release, React and React-Dom (16.0 to 16.2).

Additionally, some packages that are no longer used as direct dependancies have been removed.
  • Loading branch information
iaincollins committed Feb 6, 2018
1 parent 562d3b9 commit a8b546b
Show file tree
Hide file tree
Showing 5 changed files with 1,518 additions and 1,538 deletions.
5 changes: 1 addition & 4 deletions css/index.scss
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
@charset "UTF-8";
@import "../node_modules/bootstrap/scss/bootstrap.scss";

$ionicons-font-path: "/fonts/ionicons" !default;
$ionicons-font-family: "Ionicons" !default;
$ionicons-version: "3.0.0-alpha.3" !default;
@import "../node_modules/ionicons/dist/scss/ionicons";

@import "../node_modules/bootstrap/scss/bootstrap.scss";
@import "../node_modules/react-bootstrap-table/dist/react-bootstrap-table-all.min";

@import "nojs-menus.scss";

.lead {
Expand Down
14 changes: 0 additions & 14 deletions next.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
const webpack = require('webpack')

require('dotenv').config()

module.exports = {
webpack: (config, { dev }) => {
config.module.rules.push(
Expand All @@ -21,16 +17,6 @@ module.exports = {
loader: 'babel-loader!raw-loader!sass-loader'
}
)
config.plugins.push(
// If you want to export an environent variable from the server to the
// client (so that you can write isomorphoic code), this is how you can
// do that with webpack. Note we use dotenv module to import environment
// variables configured in .env. This can be useful for setting options
// for things like API URL hostnames.
new webpack.DefinePlugin({
'process.env.MY_ENV_VAR': JSON.stringify(process.env.MY_ENV_VAR)
})
)
return config
}
}
Loading

0 comments on commit a8b546b

Please sign in to comment.