fix manual webhook (koderover#2802)

Signed-off-by: Patrick Zhao <[email protected]>
lfp · Jul 5, 2023 · 242386f · 242386f
1 parent 8a967f5
commit 242386f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/microservice/aslan/core/workflow/service/workflow/workflow_v4.go b/pkg/microservice/aslan/core/workflow/service/workflow/workflow_v4.go
@@ -1038,10 +1038,12 @@ func UpdateWebhookForWorkflowV4(workflowName string, input *commonmodels.Workflo
 		return e.ErrUpdateWebhook.AddDesc(errMsg)
 	}
 
-	if !input.IsManual {
+	if !existHook.IsManual {
 		if err := deleteGerritWebhook(existHook.MainRepo, workflowName); err != nil {
 			logger.Errorf("delete gerrit webhook failed: %v", err)
 		}
+	}
+	if !input.IsManual {
 		if err := createGerritWebhook(input.MainRepo, workflowName); err != nil {
 			logger.Errorf("create gerrit webhook failed: %v", err)
 		}