Skip to content

Commit

Permalink
Deprecate thread_scheduling_group in favor of scheduling_group
Browse files Browse the repository at this point in the history
scheduling_group provides better functionality (inheritance along continuation
chains, submit_to() calls, and even RPC) and better performance as it doesn't
require a high precision timer per thread. It is time to deprecate
thread_scheduling_group with a view to retiring it later.
Message-Id: <[email protected]>
  • Loading branch information
avikivity authored and duarten committed Feb 16, 2019
1 parent 9080d2a commit 2313dec
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion include/seastar/core/thread.hh
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,10 @@ private:
/// After those events, if the thread has already run for more than its fraction, it will be scheduled to
/// run again only after \c period completes, unless there are no other tasks to run (the system is
/// idle)
class thread_scheduling_group {
///
/// \deprecated This class has been replaced by \ref scheduling_group, which can be used to schedule
/// both threads and continuations.
class [[deprecated("Use seastar::scheduling_group instead")]] thread_scheduling_group {
std::chrono::nanoseconds _period;
std::chrono::nanoseconds _quota;
std::chrono::time_point<thread_clock> _this_period_ends = {};
Expand Down

0 comments on commit 2313dec

Please sign in to comment.