Skip to content

Commit

Permalink
build: Allow deprecated declarations internally
Browse files Browse the repository at this point in the history
With this change, if code internal to the Seastar repository references
a deprecated declaration then we will issue a warning but not trigger an
error.

This is consistent with the way Seastar behaved prior to the switch to
CMake.

Fixes scylladb#602

Tests: dist (release)
Signed-off-by: Jesse Haber-Kucharsky <[email protected]>
Message-Id: <7335649f868c36ff76b6c0bf21677d96441bc9e4.1550080427.git.jhaberku@scylladb.com>
  • Loading branch information
Jesse Haber-Kucharsky authored and avikivity committed Feb 14, 2019
1 parent a471e14 commit 861da6e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,8 @@ set (Seastar_DEVELOPMENT_FLAGS
-fvisibility=hidden
-UNDEBUG
-Wall
-Werror)
-Werror
-Wno-error=deprecated-declarations)

if (Seastar_COMPRESS_DEBUG)
# -gz doesn't imply -g, so it is safe to add it regardless of debug
Expand Down

0 comments on commit 861da6e

Please sign in to comment.