Quartz: Don't enforce 32 bpp in older OSX releases (issue #888) #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Commit 991bbb9 added a QZ_GetModeInfo() restriction, rejecting displays < 32 bpp. It seems that SDL 1.2.15 was the first SDL 1.2 adding this restriction. But it's trivial on OSX 10.4 to have a monitor set to only "Thousands of colors" in the system preferences (especially when one uses Classic Mode or runs games requiring a lower bit depth). Moreover, it appears that it worked just fine, at least on OSX PPC 10.4/10.5. The change made some OSX PPC apps (still maintained there to this day, using SDL 1.2), such as DOSBox 0.74-3-3 or ScummVM 2.9.0, fail right after SDL_Init() with a fatal "Unsupported display mode" initialization error. Earlier releases using SDL < 1.2.15 worked fine for people using a lower bit depth on older OSX, though. So the original intent may have been to restrict to 32-bpp output for "newer" OSX releases only. Let's go for this behavior, and see if anyone reports any issue with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #888.
Commit 991bbb9 added a QZ_GetModeInfo() restriction, rejecting displays < 32 bpp. It seems that SDL 1.2.15 was the first SDL 1.2 adding this restriction.
But it's trivial on OSX 10.4 to have a monitor set to only "Thousands of colors" in the system preferences (especially when one uses Classic Mode or runs games requiring a lower bit depth). Moreover, it appears that it worked just fine, at least on OSX PPC 10.4/10.5.
The change made some OSX PPC apps (still maintained there to this day, using SDL 1.2), such as DOSBox 0.74-3-3 or ScummVM 2.9.0, fail right after SDL_Init() with a fatal "Unsupported display mode" initialization error. Earlier releases using SDL < 1.2.15 worked fine for people using a lower bit depth on older OSX, though.
So the original intent may have been to restrict to 32-bpp output for "newer" OSX releases only. Let's go for this behavior, and see if anyone reports any issue with that.