GPU: Document system requirements, add upfront Metal hardware support checks #11695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
approved these changes
Dec 24, 2024
TheSpydog
force-pushed
the
metal-device-check
branch
from
36df7f1 to
6071b91
Compare
thatcosmonaut
approved these changes
Dec 24, 2024
TheSpydog
force-pushed
the
metal-device-check
branch
from
6071b91 to
722d071
Compare
|
Updated to mention console support, and made the OS version requirements more explicit! |
TheSpydog
force-pushed
the
metal-device-check
branch
3 times, most recently
from
71db1eb to
f6b97f4
Compare
|
I can't find any information about which devices support the Mac2 gpu family. Is it only supported on apple silicon? |
|
I've tested the GPU API on my 2012 Macbook Pro which has an Nvidia card in it, so maybe that's some indication? Apple is pretty unclear about this. |
TheSpydog
force-pushed
the
metal-device-check
branch
from
f6b97f4 to
41cfdb2
Compare
|
The only place where Apple really defines what a "Mac2" device is is on the deprecated feature set page here. I've added a link to this page in the comment, hopefully that clarifies things. (We'll just have to hope that Apple doesn't take that page down anytime soon...) |
TheSpydog
force-pushed
the
metal-device-check
branch
from
41cfdb2 to
b852f01
Compare
slouken
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the OS/driver/hardware requirements for each of the SDL_GPU backends. This should hopefully clear up a lot of ambiguity around "is this device supported" and gives developers something concrete to use for their own system requirements and support.
At runtime, to ensure the device meets SDL_GPU driver's system requirements, Vulkan and D3D12 perform a series of feature support queries during the device creation process. However, for Metal, we only performed a single OS version check. This allowed apps to get pretty far into their lifecycle on unsupported devices before they crashed by using an unsupported feature.
To fix this, I've added hardware support queries as early as possible (right after MTLDevice creation) to detect if the app is running on an unsupported device, so that apps can handle the failure gracefully. I also bumped up the minimum macOS version from 10.13 to 10.14 because lower versions don't have the hardware support query we need.
Resolves #11692