Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restart from head, refactor & qol #12

Merged
merged 9 commits into from
Oct 29, 2024
Merged

feat: restart from head, refactor & qol #12

merged 9 commits into from
Oct 29, 2024

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Oct 25, 2024 •
edited
Loading

  • Use fmt.Errorf to wrap errors
  • Atomic transaction (PostgreSQL only)
    • A block and all related transactions are committed to the database in a single transaction
  • Restart indexing from where we left off
  • Fix off-by-one
  • Avoid displaying a gazillion messages when the context is canceled
  • Display retry attempts with debug log level
  • Automatic start/stop heuristic
  • Refactor
  • Disable JSON & TSV output, for now

Fixes #6

TODO

  • Add option to perform full re-index
  • More cleanup/QoL

@fmorency
feat: restart from head, refactor & qol
bf71f83 
- Use `fmt.Errorf` to wrap errors
- Atomic transaction to PostgreSQL
- Restart indexing from where we left off
- Fix off-by-one
- Avoid displaying a gazillion message when context is cancelled
@fmorency fmorency requested a review from jgryffindor October 25, 2024 19:50
@fmorency fmorency self-assigned this Oct 25, 2024
jgryffindor
jgryffindor approved these changes Oct 29, 2024
View reviewed changes
Copy link

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@fmorency fmorency marked this pull request as ready for review October 29, 2024 18:16
@fmorency fmorency merged commit c15cb34 into liftedinit:main Oct 29, 2024
@fmorency fmorency deleted the restart-head branch October 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgryffindor jgryffindor jgryffindor approved these changes

Assignees

@fmorency fmorency

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart from db head
2 participants
@fmorency @jgryffindor