Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with GCC #671

Closed
wants to merge 1 commit into from
Closed

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented May 9, 2023

Fixes a few errors reported by GCC and not Clang

  1. "non-trivial designated initializers not supported"

    • Fixed by adding array entries that were missing initializers and
      reordering
  2. "Cannot bind packed field"

    • This fixes arrays missing initializers for some entries

TODO:

  • Test in CI with GCC to prevent regressions

Fixes a few errors reported by GCC and not Clang

1. "non-trivial designated initializers not supported"

    - Fixed by adding array entries that were missing initializers and
      reordering

2. "Cannot bind packed field"

    - This fixes arrays missing initializers for some entries
@ekilmer ekilmer mentioned this pull request May 9, 2023
1 task
@ekilmer
Copy link
Contributor Author

ekilmer commented May 9, 2023

Superseded by #672

@ekilmer ekilmer closed this May 9, 2023
@ekilmer ekilmer deleted the ekilmer/fix-gcc-compilation branch May 9, 2023 22:34
@ekilmer ekilmer restored the ekilmer/fix-gcc-compilation branch May 9, 2023 22:34
@ekilmer ekilmer deleted the ekilmer/fix-gcc-compilation branch September 5, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant