Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux AArch64 compilation for SPARC32 runtime #674

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix Linux AArch64 compilation for SPARC32 runtime #674

merged 2 commits into from
May 10, 2023

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented May 10, 2023

Issue with conflicting compilation target(s).

Tests fail though.

Test project /app/builds/remill-build
    Start 1: small_diff_test
1/4 Test #1: small_diff_test ..................***Failed    0.78 sec
  0%|          | 0/1 [00:00<?, ?it/s]F20230510 16:26:03.200791 47053 InstructionLifter.cpp:651] Check failed: arg_type->isIntegerTy(impl->arch->address_size) Bad semantics function implementation for instruction at deadbe00. Integer constants that are smaller than the machine word size should be represented as machine word sized arguments to semantics functions.
*** Check failure stack trace: ***
    @     0xaaaae0483be8  google::LogMessage::SendToLog()
    @     0xaaaae0480580  google::LogMessage::Flush()
    @     0xaaaae0484200  google::LogMessageFatal::~LogMessageFatal()
    @     0xaaaae04991d0  remill::InstructionLifter::LiftImmediateOperand()
    @     0xaaaae04966d0  remill::InstructionLifter::LiftIntoBlock()
    @     0xaaaae049434c  test_runner::LiftingTester::LiftInstructionFunction()
    @     0xaaaae04946b0  test_runner::LiftingTester::LiftInstructionFunction()
    @     0xaaaae0473f44  DifferentialModuleBuilder::build()
    @     0xaaaae0472454  runTestCase()
    @     0xaaaae0473208  main
    @     0xffffa9be73fc  (unknown)
    @     0xffffa9be74cc  __libc_start_main
    @     0xaaaae0472030  _start
    @              (nil)  (unknown)
100%|██████████| 1/1 [00:00<00:00,  1.41it/s]
Ran 530 with 530 failing. Success rate of: 0.0

    Start 2: thumb-tests
2/4 Test #2: thumb-tests ......................   Passed    5.60 sec
    Start 3: ppc-tests
3/4 Test #3: ppc-tests ........................   Passed   10.93 sec
    Start 4: aarch64
Could not find executable /app/builds/remill-build/tests/AArch64/run-aarch64-tests
Looked in the following places:
/app/builds/remill-build/tests/AArch64/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Release/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Release/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Debug/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Debug/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/MinSizeRel/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/MinSizeRel/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/RelWithDebInfo/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/RelWithDebInfo/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Deployment/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Deployment/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Development/run-aarch64-tests
/app/builds/remill-build/tests/AArch64/Development/run-aarch64-tests
app/builds/remill-build/tests/AArch64/run-aarch64-tests
app/builds/remill-build/tests/AArch64/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Release/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Release/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Debug/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Debug/run-aarch64-tests
app/builds/remill-build/tests/AArch64/MinSizeRel/run-aarch64-tests
app/builds/remill-build/tests/AArch64/MinSizeRel/run-aarch64-tests
app/builds/remill-build/tests/AArch64/RelWithDebInfo/run-aarch64-tests
app/builds/remill-build/tests/AArch64/RelWithDebInfo/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Deployment/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Deployment/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Development/run-aarch64-tests
app/builds/remill-build/tests/AArch64/Development/run-aarch64-tests
Unable to find executable: /app/builds/remill-build/tests/AArch64/run-aarch64-tests
4/4 Test #4: aarch64 ..........................***Not Run   0.00 sec

50% tests passed, 2 tests failed out of 4

Total Test time (real) =  17.32 sec

The following tests FAILED:
          1 - small_diff_test (Failed)
          4 - aarch64 (Not Run)

@ekilmer
Fix Linux AArch64 compilation for SPARC32 runtime
344e85a 
Issue with conflicting compilation target(s).

Tests fail though.
@ekilmer ekilmer force-pushed the ekilmer/fix-arm-compilation branch from bc87759 to 344e85a Compare May 10, 2023 21:11
@ekilmer ekilmer marked this pull request as ready for review May 10, 2023 21:46
@ekilmer ekilmer requested a review from pgoodman as a code owner May 10, 2023 21:46
@ekilmer ekilmer merged commit 396e228 into master May 10, 2023
@ekilmer ekilmer deleted the ekilmer/fix-arm-compilation branch May 10, 2023 22:38
xlauko pushed a commit that referenced this pull request Aug 9, 2023
@ekilmer @xlauko
Fix Linux AArch64 compilation for SPARC32 runtime (#674)
a4174ae 
* Fix Linux AArch64 compilation for SPARC32 runtime

Issue with conflicting compilation target(s).

Tests fail though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ninja3047 Ninja3047 Ninja3047 left review comments

@pgoodman pgoodman pgoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekilmer @pgoodman @Ninja3047