Fix some XSS issues in settings.php

Signed-off-by: Mcat12 <[email protected]>
lightswitch05 · Sep 18, 2019 · d23df61 · d23df61
1 parent bfe7b76
commit d23df61
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/settings.php b/settings.php
@@ -787,7 +787,7 @@ function convertseconds($argument)
                                                     <div class="radio">
                                                         <label><input type="radio" name="DNSinterface" value="single"
                                                                       <?php if ($DNSinterface == "single"){ ?>checked<?php } ?>>
-                                                               <strong>Listen only on interface <?php echo $piHoleInterface; ?></strong>
+                                                               <strong>Listen only on interface <?php echo htmlentities($piHoleInterface); ?></strong>
                                                         </label>
                                                     </div>
                                                     <div class="radio">
@@ -1196,19 +1196,19 @@ function convertseconds($argument)
                                                 <tbody>
                                                 <tr>
                                                     <th scope="row">Pi-hole Ethernet Interface:</th>
-                                                    <td><?php echo $piHoleInterface; ?></td>
+                                                    <td><?php echo htmlentities($piHoleInterface); ?></td>
                                                 </tr>
                                                 <tr>
                                                     <th scope="row">Pi-hole IPv4 address:</th>
-                                                    <td><?php echo $piHoleIPv4; ?></td>
+                                                    <td><?php echo htmlentities($piHoleIPv4); ?></td>
                                                 </tr>
                                                 <tr>
                                                     <th scope="row">Pi-hole IPv6 address:</th>
-                                                    <td><?php echo $piHoleIPv6; ?></td>
+                                                    <td><?php echo htmlentities($piHoleIPv6); ?></td>
                                                 </tr>
                                                 <tr>
                                                     <th scope="row">Pi-hole hostname:</th>
-                                                    <td><?php echo $hostname; ?></td>
+                                                    <td><?php echo htmlentities($hostname); ?></td>
                                                 </tr>
                                                 </tbody>
                                             </table>