Skip to content

Commit

Permalink
mds: fix MDRequestImpl::print override
Browse files Browse the repository at this point in the history
Fixes compiler warnings:

In file included from /home/cbodley/ceph/src/mds/Locker.cc:22:0:
/home/cbodley/ceph/src/mds/Mutation.h:161:16: warning: ‘virtual void
MutationImpl::print(std::ostream&) const’ was hidden
[-Woverloaded-virtual]
   virtual void print(ostream &out) const {
                ^
/home/cbodley/ceph/src/mds/Mutation.h:340:8: warning:   by ‘void
MDRequestImpl::print(std::ostream&)’ [-Woverloaded-virtual]
   void print(ostream &out);

Signed-off-by: Casey Bodley <[email protected]>
  • Loading branch information
cbodley committed Jun 6, 2016
1 parent 944a895 commit 42e0847
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/mds/Mutation.cc
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ void MDRequestImpl::set_filepath2(const filepath& fp)
more()->filepath2 = fp;
}

void MDRequestImpl::print(ostream &out)
void MDRequestImpl::print(ostream &out) const
{
out << "request(" << reqid;
//if (request) out << " " << *request;
Expand Down
4 changes: 2 additions & 2 deletions src/mds/Mutation.h
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@ struct MDRequestImpl : public MutationImpl, public TrackedOp {
void set_filepath(const filepath& fp);
void set_filepath2(const filepath& fp);

void print(ostream &out);
void dump(Formatter *f) const;
void print(ostream &out) const override;
void dump(Formatter *f) const override;

// TrackedOp stuff
typedef ceph::shared_ptr<MDRequestImpl> Ref;
Expand Down

0 comments on commit 42e0847

Please sign in to comment.