Update doc for the HTTP_METHOD_SPECIFY property item (alibaba#1091)

lingzhi-wlz · Nov 6, 2019 · b6c2979 · b6c2979
1 parent 7c2c137
commit b6c2979
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/sentinel-adapter/sentinel-web-servlet/README.md b/sentinel-adapter/sentinel-web-servlet/README.md
@@ -39,7 +39,8 @@ public class FilterConfig {
         registration.addUrlPatterns("/*");
         registration.setName("sentinelCommonFilter");
         registration.setOrder(1);
-
+        // Set whether to support the specified HTTP method for the filter.
+        registration.addInitParameter(CommonFilter.HTTP_METHOD_SPECIFY, "false");
         return registration;
     }
 }

diff --git a/...inel-web-servlet/src/main/java/com/alibaba/csp/sentinel/adapter/servlet/CommonFilter.java b/...inel-web-servlet/src/main/java/com/alibaba/csp/sentinel/adapter/servlet/CommonFilter.java
@@ -48,7 +48,7 @@
  */
 public class CommonFilter implements Filter {
 
-    private final static String HTTP_METHOD_SPECIFY = "HTTP_METHOD_SPECIFY";
+    public final static String HTTP_METHOD_SPECIFY = "HTTP_METHOD_SPECIFY";
     /**
      * Use the path of the url as the context, if necessary, but pay attention to the number of context EntranceNode
      */

diff --git a/...vlet/src/test/java/com/alibaba/csp/sentinel/adapter/servletmethod/FilterMethodConfig.java b/...vlet/src/test/java/com/alibaba/csp/sentinel/adapter/servletmethod/FilterMethodConfig.java
@@ -16,7 +16,7 @@ public FilterRegistrationBean sentinelFilterRegistration() {
         FilterRegistrationBean registration = new FilterRegistrationBean();
         registration.setFilter(new CommonFilter());
         registration.addUrlPatterns("/*");
-        registration.addInitParameter("HTTP_METHOD_SPECIFY", "true");
+        registration.addInitParameter(CommonFilter.HTTP_METHOD_SPECIFY, "true");
         registration.setName("sentinelFilter");
         registration.setOrder(1);