Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing direct Perl dependency TimeDate for command genhtml #375

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented Jan 7, 2025

Side product of https://bugs.gentoo.org/947646

Not to be confused with DateTime 😃 (which did happen to me)

# git --no-pager grep Date::Parse
bin/genhtml:use Date::Parse;
bin/genhtml:            my $epoch = Date::Parse::str2time($baseline_date);

https://metacpan.org/pod/Date::Parse

@hartwork hartwork force-pushed the add-missing-direct-perl-dependency branch from 4e9bf99 to 8a00637 Compare January 7, 2025 01:18
@henry2cox
Copy link
Collaborator

Can you go ahead and add a 'Signed-off-by' field to the PR comment?
I think we need that before merging. (Yeah - pedantic. Sorry.)

.. for command genhtml.  Not to be mixed up with DateTime,
which is also needed (but already documented).

Signed-off-by: Sebastian Pipping <[email protected]>
@hartwork
Copy link
Contributor Author

hartwork commented Jan 7, 2025

@henry2cox no worries, it's been a while since my last commit here. git rebase --signoff master did all the work for me, done, pushed.

@hartwork hartwork force-pushed the add-missing-direct-perl-dependency branch from 8a00637 to 55d9438 Compare January 7, 2025 16:02
@henry2cox henry2cox merged commit ecec956 into linux-test-project:master Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants