Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the --tempdir option from lcov to geninfo #379

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

madscientist
Copy link
Contributor

lcov invokes geninfo but didn't provide it with the user's --tempdir option value (if specified); pass it down.

lcov invokes geninfo but didn't provide it with the user's --tempdir
option value (if specified); pass it down.

Signed-off-by: Paul Smith <[email protected]>
@henry2cox
Copy link
Collaborator

Well damn.
No sooner make a release than someone finds a bug.

Thanks for the fix!

@henry2cox henry2cox merged commit 39e7323 into linux-test-project:master Jan 9, 2025
5 checks passed
@madscientist
Copy link
Contributor Author

Yeah, sorry about that I keep getting pulled away this week so it took a few more days to get the PR in. In the abstract it would probably be cleaner to add a function to lcovutil which computes a list of the common lcovutil-supported options, that other tools could utilize to invoke each other while preserving command line args. But I didn't want to go that far :)

@madscientist madscientist deleted the pds/tempdir branch January 10, 2025 13:43
@henry2cox
Copy link
Collaborator

That is pretty much what the implementation already does - except that the lcov/geninfo is different :-(.

What I actually wanted to do (but haven't gotten to) is to move the common 'capture' functionality into a library - then simply invoke from either lcov or geninfo.
Has never risen to the top of the todo list.

More than happy, if someone wants to take that on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants