Небольшие изменения в класс новой почты #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1KO
reviewed
May 18, 2022
src/Delivery/Array2Xml.php
Outdated
| */ | ||
| public function array2xml(array $array, $xml = false) | ||
| { | ||
| (false === $xml) and $xml = new \SimpleXMLElement('<root/>'); |
There was a problem hiding this comment.
так делать плохо, используй простой иф, это ухудшает читаемость и понимание кода
src/Delivery/PrepareReturnData.php
Outdated
| public function prepare($data) | ||
| { | ||
| // Returns array | ||
| if ('array' == $this->format) { |
There was a problem hiding this comment.
Если тут сделать НЕ равно и сразу ретурн то уменьшится вложенность кода
| <?php | ||
| namespace LisDev\Delivery; | ||
|
|
||
| // Вынес из NovaPoshtaApi2.php методы связанные с печатью интернет документов. |
| return $this->printGetLink('printDocument', $documentRefs, $type); | ||
| } | ||
| // If needs data | ||
| return $this->request('InternetDocument', 'printDocument', array('DocumentRefs' => $documentRefs, 'Type' => $type)); |
|
|
||
| $prepare = new PrepareReturnData(); | ||
| $array2xml = new Array2Xml(); | ||
|
|
||
| // Convert data to neccessary format | ||
| $post = 'xml' == $this->format |
There was a problem hiding this comment.
На самом деле логику преобразования данных в нужный формат стоило вынести в отдельную иерархию абстракций, как раз таки в PrepareReturnData
| // Convert data to neccessary format | ||
| $post = 'xml' == $this->format | ||
| ? $this->array2xml($data) | ||
| ? $array2xml->array2xml($data) | ||
| : json_encode($data); | ||
|
|
||
| if ('curl' == $this->getConnectionType()) { |
There was a problem hiding this comment.
Этому здесь не место. Транспорт нужно выносить отдельно от логики
R1KO
reviewed
May 23, 2022
| // Convert data to neccessary format | ||
| $post = 'xml' == $this->format | ||
| ? $array2xml->array2xml($data) | ||
| : json_encode($data); | ||
|
|
||
| /* | ||
| * Здесь тоже самое, я не понимаю как вынести этот транспорт из метода реквест, чтобы потом в нём использовать. |
There was a problem hiding this comment.
public function __construct($key, $language = 'ru', $throwErrors = false, ConnectionInterface $connection)
$this->connection->getData();
class CurlConnection implements ConnectionInterface {
// implementation
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Хотел сделать рефакторинг хотя бы по принципу единой ответственности.
Вынес несколько методов в отдельные классы.
Но потом пришло понимание что делаю что-то не то.
В обшем на этом пока остановился.