Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

fix(limit): invalidate oldest cache when reaching limit size #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhenwenc
Copy link

@zhenwenc zhenwenc commented May 19, 2021

When the number of cached requests reaches the configured limit, the oldest cached item should be removed from the store.

#247

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #248 (4d16e29) into master (2d51cee) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          235       238    +3     
=========================================
+ Hits           235       238    +3     
Impacted Files Coverage Δ
src/memory.js 100.00% <100.00%> (ø)
src/redis.js 100.00% <100.00%> (ø)
src/serialize.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d51cee...4d16e29. Read the comment docs.

Copy link

@cowboy-bebug cowboy-bebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid to me 👍

@cowboy-bebug
Copy link

cc @RasCarlito

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants