[thrift] generate initialization only when strictly needed, see robot…

…ology#370
liujiandu · Feb 23, 2015 · 5d19db3 · 5d19db3
1 parent 7865aff
commit 5d19db3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/idls/thrift/src/t_yarp_generator.cc b/src/idls/thrift/src/t_yarp_generator.cc
@@ -2074,7 +2074,9 @@ void t_yarp_generator::generate_service(t_service* tservice) {
           t_type* returntype = (*fn_iter)->get_returntype();
           t_field returnfield(returntype, "_return");
           if (!returntype->is_void()) {
-            indent(f_curr_) << declare_field(&returnfield, true,false,false,false,"") << endl;
+	    if (returntype->is_base_type()||returntype->is_enum()) {
+	      indent(f_curr_) << declare_field(&returnfield, true,false,false,false,"") << endl;
+	    }
           }
           vector<t_field*> args = (*fn_iter)->get_arglist()->get_members();
           vector<t_field*>::iterator arg_iter = args.begin();

diff --git a/src/idls/thrift/tests/demo/demo.thrift b/src/idls/thrift/tests/demo/demo.thrift
@@ -90,4 +90,6 @@ service Demo {
   oneway void do_start_a_service();
   bool do_check_for_service();
   void do_stop_a_service();
+
+  DemoStruct get_demo_struct();
 }