validate participating-sigs as well

liuyangc3 · Jan 19, 2020 · c65e917 · c65e917
1 parent 35383bb
commit c65e917
Show file tree

Hide file tree

Showing 27 changed files with 28 additions and 55 deletions.
diff --git a/keps/0001-kubernetes-enhancement-proposal-process.md b/keps/0001-kubernetes-enhancement-proposal-process.md
@@ -4,8 +4,6 @@ authors:
   - "@calebamiles"
   - "@jbeda"
 owning-sig: sig-architecture
-participating-sigs:
-  - kubernetes-wide
 reviewers:
   - "@timothysc"
 approvers:

diff --git a/keps/sig-api-machinery/20190226-network-proxy.md b/keps/sig-api-machinery/20190226-network-proxy.md
@@ -5,7 +5,7 @@ authors:
   - "@anfernee"
 owning-sig: sig-api-machinery
 participating-sigs:
-  - sig-networking
+  - sig-network
   - sig-cloud-provider
 reviewers:
   - TBD

diff --git a/keps/sig-api-machinery/20190927-insecure-backend-proxy.md b/keps/sig-api-machinery/20190927-insecure-backend-proxy.md
@@ -4,7 +4,7 @@ authors:
   - "@deads2k"
 owning-sig: sig-api-machinery
 participating-sigs:
-  - sig-apimachinery
+  - sig-api-machinery
   - sig-auth
   - sig-cli
 reviewers:

diff --git a/keps/sig-auth/20190711-external-credential-providers.md b/keps/sig-auth/20190711-external-credential-providers.md
@@ -4,7 +4,8 @@ authors:
   - "@awly"
 owning-sig: sig-auth
 participating-sigs:
-  - sig-cli, sig-api-machinery
+  - sig-cli
+  - sig-api-machinery
 reviewers:
   - "@liggitt"
   - "@mikedanese"

diff --git a/keps/sig-cli/20190920-future-of-kubectl-cp.md b/keps/sig-cli/20190920-future-of-kubectl-cp.md
@@ -4,7 +4,7 @@ authors:
   - "@sallyom"
 owning-sig: sig-cli
 participating-sigs:
-  - sig-Usability
+  - sig-usability
 reviewers:
   - "@liggitt"
   - "@brendandburns"

diff --git a/keps/sig-cloud-provider/0018-testgrid-conformance-e2e.md b/keps/sig-cloud-provider/0018-testgrid-conformance-e2e.md
@@ -6,12 +6,6 @@ owning-sig: sig-cloud-provider
 participating-sigs:
   - sig-testing
   - sig-release
-  - sig-aws
-  - sig-azure
-  - sig-gcp
-  - sig-ibmcloud
-  - sig-openstack
-  - sig-vmware
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-cloud-provider/20180530-cloud-controller-manager.md b/keps/sig-cloud-provider/20180530-cloud-controller-manager.md
@@ -6,11 +6,7 @@ authors:
   - "@hogepodge"
 owning-sig: sig-api-machinery
 participating-sigs:
-  - sig-aws
-  - sig-azure
   - sig-cloud-provider
-  - sig-gcp
-  - sig-openstack
   - sig-storage
 reviewers:
   - "@andrewsykim"

diff --git a/keps/sig-cloud-provider/20180731-cloud-provider-docs.md b/keps/sig-cloud-provider/20180731-cloud-provider-docs.md
@@ -8,11 +8,6 @@ owning-sig: sig-cloud-provider
 participating-sigs:
   - sig-docs
   - sig-cluster-lifecycle
-  - sig-aws
-  - sig-azure
-  - sig-gcp
-  - sig-openstack
-  - sig-vmware
 reviewers:
   - "@andrewsykim"
   - "@calebamiles"

diff --git a/keps/sig-cloud-provider/20190125-out-of-tree-aws.md b/keps/sig-cloud-provider/20190125-out-of-tree-aws.md
@@ -3,8 +3,6 @@ title: Support Out-of-Tree AWS Cloud Provider
 authors:
   - "@andrewsykim"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-aws
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-cloud-provider/20190125-out-of-tree-gce.md b/keps/sig-cloud-provider/20190125-out-of-tree-gce.md
@@ -3,8 +3,6 @@ title: Support Out-of-Tree GCE Cloud Provider
 authors:
   - "@andrewsykim"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-gcp
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-cloud-provider/20190125-out-of-tree-ibm.md b/keps/sig-cloud-provider/20190125-out-of-tree-ibm.md
@@ -3,8 +3,6 @@ title: Support Out-of-Tree IBM Cloud Provider
 authors:
   - "@andrewsykim"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-ibm
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-cloud-provider/20190125-out-of-tree-openstack.md b/keps/sig-cloud-provider/20190125-out-of-tree-openstack.md
@@ -4,8 +4,6 @@ authors:
   - "@andrewsykim"
   - "@adisky"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-openstack
 reviewers:
   - "@lingxiankong"
   - "@chrigl"

diff --git a/keps/sig-cloud-provider/20190125-out-of-tree-vsphere.md b/keps/sig-cloud-provider/20190125-out-of-tree-vsphere.md
@@ -4,8 +4,6 @@ authors:
   - "@frapposelli"
   - "@andrewsykim"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-vmware
 reviewers:
   - "@frapposelli"
   - "@cantbewong"

diff --git a/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md b/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md
@@ -6,12 +6,8 @@ authors:
 owning-sig: sig-cloud-provider
 participating-sigs:
   - sig-apps
-  - sig-aws
-  - sig-azure
-  - sig-apimachinery
-  - sig-gcp
+  - sig-api-machinery
   - sig-network
-  - sig-openstack
   - sig-storage
 reviewers:
   - "@andrewsykim"

diff --git a/keps/sig-cloud-provider/20190422-cloud-controller-manager-migration.md b/keps/sig-cloud-provider/20190422-cloud-controller-manager-migration.md
@@ -4,7 +4,7 @@ authors:
   - "@andrewsykim"
 owning-sig: sig-cloud-provider
 participating-sigs:
-  - sig-apimachinery
+  - sig-api-machinery
 reviewers:
   - "@cheftako"
   - "@mcrute"

diff --git a/keps/sig-cloud-provider/azure/20180711-azure-availability-zones.md b/keps/sig-cloud-provider/azure/20180711-azure-availability-zones.md
@@ -4,7 +4,6 @@ authors:
   - "@feiskyer"
 owning-sig: sig-cloud-provider
 participating-sigs:
-  - sig-azure
   - sig-storage
 reviewers:
   - "@khenidak"

diff --git a/keps/sig-cloud-provider/azure/20180809-cross-resource-group-nodes.md b/keps/sig-cloud-provider/azure/20180809-cross-resource-group-nodes.md
@@ -3,8 +3,6 @@ title: Cross resource group nodes
 authors:
   - "@feiskyer"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-azure
 reviewers:
   - "@khenidak"
   - "@justaugustus"

diff --git a/keps/sig-cloud-provider/azure/20190125-out-of-tree-azure.md b/keps/sig-cloud-provider/azure/20190125-out-of-tree-azure.md
@@ -5,8 +5,6 @@ authors:
   - "@dstrebel"
   - "@feiskyer"
 owning-sig: sig-cloud-provider
-participating-sigs:
-  - sig-azure
 reviewers:
   - "@dstrebel"
   - "@justaugustus"

diff --git a/keps/sig-instrumentation/20190425-metrics-watch-api.md b/keps/sig-instrumentation/20190425-metrics-watch-api.md
@@ -5,7 +5,6 @@ authors:
 owning-sig: sig-instrumentation
 participating-sigs:
   - sig-autoscaling
-  - (?)
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-network/20180612-ipv4-ipv6-dual-stack.md b/keps/sig-network/20180612-ipv4-ipv6-dual-stack.md
@@ -8,7 +8,7 @@ authors:
   - "feiskyer@"
 owning-sig: sig-network
 participating-sigs:
-  - sig-clusterlifecycle
+  - sig-cluster-lifecycle
 reviewers:
   - TBD
 approvers:

diff --git a/keps/sig-node/0009-node-heartbeat.md b/keps/sig-node/0009-node-heartbeat.md
@@ -6,7 +6,7 @@ authors:
 owning-sig: sig-node
 participating-sigs:
   - sig-scalability
-  - sig-apimachinery
+  - sig-api-machinery
   - sig-scheduling
 reviewers:
   - "@deads2k"

diff --git a/keps/sig-release/20190316-rebase-images-to-distroless.md b/keps/sig-release/20190316-rebase-images-to-distroless.md
@@ -5,7 +5,7 @@ authors:
 owning-sig: sig-release
 participating-sigs:
   - sig-release
-  - cloud-provider
+  - sig-cloud-provider
 reviewers:
   - "@tallclair"
 approvers:

diff --git a/keps/sig-release/20190331-release-notes.md b/keps/sig-release/20190331-release-notes.md
@@ -4,7 +4,7 @@ authors:
   - "@jeefy"
 owning-sig: sig-release
 participating-sigs:
-  - sig-contribex
+  - sig-contributor-experience
   - sig-docs
 reviewers:
   - "@spiffxp"
@@ -162,4 +162,4 @@ A GitHub repo will need to be setup to host code for both the `release-notes` to
 new release notes website. Said repo will also need to be integrated with Netlify for hosting. An
 initial design idea to power the automatic generation of release notes was to use a Knative pipeline.
 This would require a Kubernetes cluster to run on, as well as a GitHub token and webhook registration.
-Lastly, a DNS entry will be needed to point to the Netlify site (proposal: relnotes.k8s.io)
+Lastly, a DNS entry will be needed to point to the Netlify site (proposal: relnotes.k8s.io)
diff --git a/keps/sig-release/k8s-image-promoter.md b/keps/sig-release/k8s-image-promoter.md
@@ -4,7 +4,7 @@ authors:
   - "@javier-b-perez"
 owning-sig: sig-release
 participating-sigs:
-  - TBD
+  - wg-k8s-infra
 reviewers:
   - "@AishSundar"
   - "@BenTheElder"

diff --git a/keps/sig-scheduling/20190409-resource-quota-ga.md b/keps/sig-scheduling/20190409-resource-quota-ga.md
@@ -5,7 +5,7 @@ authors:
 owning-sig: sig-api-machinery
 participating-sigs:
   - sig-scheduling
-  - sig-apimachinery
+  - sig-api-machinery
 reviewers:
   - "@bsalamat"
   - "@k82cn"

diff --git a/keps/sig-storage/20190129-csi-migration.md b/keps/sig-storage/20190129-csi-migration.md
@@ -5,7 +5,7 @@ authors:
   - "@jsafrane"
 owning-sig: sig-storage
 participating-sigs:
-  - sig-arch
+  - sig-architecture
   - sig-cluster-lifecycle
 reviewers:
   - "@saadali"
@@ -129,4 +129,4 @@ Major milestones in the life cycle of a KEP should be tracked in `Implementation
 Major milestones might include
 
 - 2019-01-29 KEP Created
-- 2019-01-05 Implementation started
+- 2019-01-05 Implementation started
diff --git a/pkg/kepval/keps/validations/yaml.go b/pkg/kepval/keps/validations/yaml.go
@@ -185,13 +185,22 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			}
 			fallthrough
 		case "authors", "reviewers", "approvers":
-			switch v := value.(type) {
+			switch values := value.(type) {
 			case []interface{}:
-				if len(v) == 0 {
+				if len(values) == 0 {
 					return &MustHaveAtLeastOneValue{k}
 				}
+				if strings.ToLower(k) == "participating-sigs" {
+					for _, value := range values {
+						v := value.(string)
+						index := sort.SearchStrings(listSIGsAndWGs, v)
+						if index >= len(listSIGsAndWGs) || listSIGsAndWGs[index] != v {
+							return &ValueMustBeOneOf{k, v, listSIGsAndWGs}
+						}
+					}
+				}
 			case interface{}:
-				return &ValueMustBeListOfStrings{k, v}
+				return &ValueMustBeListOfStrings{k, values}
 			}
 		}
 	}