Skip to content

Commit

Permalink
Add new protobuf message to report app deployment statuses (#2634)
Browse files Browse the repository at this point in the history
  • Loading branch information
aleDsz authored Jun 3, 2024
1 parent 829b6b2 commit f01e212
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 1 deletion.
8 changes: 8 additions & 0 deletions proto/lib/livebook_proto/app_deployment_status.pb.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
defmodule LivebookProto.AppDeploymentStatus do
use Protobuf, syntax: :proto3, protoc_gen_elixir_version: "0.12.0"

field :id, 1, type: :string
field :deployment_group_id, 2, type: :string, json_name: "deploymentGroupId"
field :version, 3, type: :string
field :status, 4, type: :string
end
8 changes: 8 additions & 0 deletions proto/lib/livebook_proto/app_deployment_status_report.pb.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
defmodule LivebookProto.AppDeploymentStatusReport do
use Protobuf, syntax: :proto3, protoc_gen_elixir_version: "0.12.0"

field :app_deployment_statuses, 1,
repeated: true,
type: LivebookProto.AppDeploymentStatus,
json_name: "appDeploymentStatuses"
end
11 changes: 11 additions & 0 deletions proto/messages.proto
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,17 @@ message Agent {
string deployment_group_id = 4;
}

message AppDeploymentStatus {
string id = 1;
string deployment_group_id = 2;
string version = 3;
string status = 4;
}

message AppDeploymentStatusReport {
repeated AppDeploymentStatus app_deployment_statuses = 1;
}

message Event {
oneof type {
SecretCreated secret_created = 1;
Expand Down
1 change: 0 additions & 1 deletion test/livebook_teams/hubs/team_client_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,6 @@ defmodule Livebook.Hubs.TeamClientTest do
# Since the app deployment struct generation is from Livebook side,
# we don't have yet the information about who deployed the app,
# so we need to add it ourselves.

app_deployment = %{
app_deployment
| id: to_string(teams_app_deployment.id),
Expand Down

0 comments on commit f01e212

Please sign in to comment.