AMBARI-25516. Missing @OverRide on 91 methods (apache#3198) (rickyma …

…via dgrinenko)

ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkConnection.java

@@ -41,6 +41,7 @@ public static ZooKeeper open(String serverAddress, int sessionTimeoutMillis, int
   {
     final CountDownLatch connSignal = new CountDownLatch(1);
     ZooKeeper zooKeeper = new ZooKeeper(serverAddress, sessionTimeoutMillis, new Watcher() {
+      @Override
       public void process(WatchedEvent event) {
         if (event.getState() == SyncConnected) {
           connSignal.countDown();

ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ServiceComponentHostEventWrapper.java

@@ -66,6 +66,7 @@ public String getEventJson() {
     }
   }
 
+  @Override
   public String toString() {
     if (event != null) {
       return event.toString();

ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java

@@ -445,6 +445,7 @@ private String getDiskString() {
     return ret.toString();
   }
 
+  @Override
   public String toString() {
     return "[" +
         "hostname=" + this.hostname + "," +

ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultImpl.java

@@ -88,10 +88,12 @@ public void setResultStatus(ResultStatus status) {
     m_status = status;
   }
 
+  @Override
   public void setResultMetadata(ResultMetadata resultMetadata) {
     m_resultMetadata = resultMetadata;
   }
 
+  @Override
   public ResultMetadata getResultMetadata() {
     return m_resultMetadata;
   }

ambari-server/src/main/java/org/apache/ambari/server/bootstrap/FifoLinkedHashMap.java

@@ -29,6 +29,7 @@
 public class FifoLinkedHashMap<K, V> extends
 LinkedHashMap<K, V> {
   public static final int MAX_ENTRIES = 100;
+  @Override
   protected boolean removeEldestEntry(Map.Entry<K,
       V> eldest) {
     return size() > MAX_ENTRIES;

ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java

@@ -73,6 +73,7 @@ protected CleanupServiceImpl(Set<Cleanable> cleanables) {
    * @param cleanupPolicy the policy based on which the cleanup is done
    * @return the number of affected rows
    */
+  @Override
   public CleanupResult cleanup(TimeBasedCleanupPolicy cleanupPolicy) {
     long affectedRows = 0;
     int errorCount = 0;

ambari-server/src/main/java/org/apache/ambari/server/configuration/SingleFileWatch.java

@@ -89,6 +89,7 @@ public void stop() {
     watchdog.interrupt();
   }
 
+  @Override
   public String toString() {
     return "SingleFileWatcher:" + file.getName();
   }

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java

@@ -870,6 +870,7 @@ void persistServiceComponentHosts(Set<ServiceComponentHostRequest> requests, boo
   /**
    * {@inheritDoc}
    */
+  @Override
   public TopologyUpdateEvent getAddedComponentsTopologyEvent(Set<ServiceComponentHostRequest> requests)
     throws AmbariException {
     TreeMap<String, TopologyCluster> topologyUpdates = new TreeMap<>();

ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java

@@ -112,6 +112,7 @@ public String getHostGroupName() {
     return hostGroup;
   }
 
+  @Override
   public String toString() {
     return "{ hostname=" + hostname + ", clusterName=" + clusterName + " }";
   }

ambari-server/src/main/java/org/apache/ambari/server/controller/ShortTaskStatus.java

@@ -142,6 +142,7 @@ public void setStatus(String status) {
     this.status = status;
   }
 
+  @Override
   public String toString() {
     StringBuilder sb = new StringBuilder();
     sb.append("ShortTaskStatusDump ")

ambari-server/src/main/java/org/apache/ambari/server/controller/ViewPrivilegeRequest.java

@@ -36,6 +36,7 @@ public class ViewPrivilegeRequest extends ViewPrivilegeResponse implements ApiMo
    * Hide privilege id in request body schema
    * @return privilege id
    */
+  @Override
   @ApiModelProperty(name = PrivilegeResourceProvider.PRIVILEGE_ID_PROPERTY_ID, hidden = true)
   public Integer getPrivilegeId() {
     return privilegeId;
@@ -45,6 +46,7 @@ public Integer getPrivilegeId() {
    * Hide permission label in request body schema
    * @return permission label
    */
+  @Override
   @ApiModelProperty(name = PrivilegeResourceProvider.PERMISSION_LABEL_PROPERTY_ID, hidden = true)
   public String getPermissionLabel() {
     return permissionLabel;
@@ -54,6 +56,7 @@ public String getPermissionLabel() {
    * Hide view name in request body schema
    * @return view name
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.VIEW_NAME_PROPERTY_ID, hidden = true)
   public String getViewName() {
     return viewName;
@@ -63,6 +66,7 @@ public String getViewName() {
    * Hide view version in request body schema
    * @return view version
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.VERSION_PROPERTY_ID, hidden = true)
   public String getVersion() {
     return version;
@@ -72,6 +76,7 @@ public String getVersion() {
    * Hide view instance name in request body schema
    * @return view instance name
    */
+  @Override
   @ApiModelProperty(name = ViewPrivilegeResourceProvider.INSTANCE_NAME_PROPERTY_ID, hidden = true)
   public String getInstanceName() {
     return instanceName;

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AppCookieManager.java

@@ -196,10 +196,12 @@ static String getHadoopAuthCookieValue(Header[] headers) {
 
   private static class EmptyJaasCredentials implements Credentials {
 
+    @Override
     public String getPassword() {
       return null;
     }
 
+    @Override
     public Principal getUserPrincipal() {
       return null;
     }

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java

@@ -131,6 +131,7 @@ public Void invoke() throws AmbariException {
     return getRequestStatus(null);
   }
 
+  @Override
   protected RequestStatus deleteResourcesAuthorized(Request request, Predicate predicate)
         throws SystemException, UnsupportedPropertyException,
         NoSuchResourceException, NoSuchParentResourceException {

ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java

@@ -156,6 +156,7 @@ public void setLogSearchReadTimeoutInMilliseconds(int logSearchReadTimeoutInMill
     this.logSearchReadTimeoutInMilliseconds = logSearchReadTimeoutInMilliseconds;
   }
 
+  @Override
   public LogQueryResponse sendQueryRequest(Map<String, String> queryParameters) {
     try {
       // use the Apache builder to create the correct URI
@@ -302,6 +303,7 @@ private String getLogSearchAdminPassword() {
     return null;
   }
 
+  @Override
   public HostLogFilesResponse sendGetLogFileNamesRequest(String hostName) {
     try {
       // use the Apache builder to create the correct URI

ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java

@@ -64,6 +64,7 @@ public String getHash() {
     return hash;
   }
 
+  @Override
   public void setHash(String hash) {
     this.hash = hash;
   }

ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java

@@ -81,10 +81,12 @@ public UpdateEventType getEventType() {
     return eventType;
   }
 
+  @Override
   public String getHash() {
     return hash;
   }
 
+  @Override
   public void setHash(String hash) {
     this.hash = hash;
   }

ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java

@@ -199,6 +199,7 @@ public boolean disableEndpointIdentification() {
     return Boolean.valueOf(configValue(AmbariServerConfigurationKey.DISABLE_ENDPOINT_IDENTIFICATION));
   }
 
+  @Override
   public Map<String, String> toMap() {
     return new HashMap<>(configurationMap);
   }

ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java

@@ -300,10 +300,12 @@ protected String getHostname() {
     return hostName;
   }
 
+  @Override
   protected boolean isHostInMemoryAggregationEnabled() {
     return false;
   }
 
+  @Override
   protected int getHostInMemoryAggregationPort() {
     return 0;
   }

ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java

@@ -99,6 +99,7 @@ public String getType() {
      * {@inheritDoc}
      * Uses default Ambari OIDs
      */
+    @Override
     protected PDU prepareTrap(Notification notification, SnmpVersion snmpVersion) throws InvalidSnmpConfigurationException {
         AlertNotification alertNotification;
         PDU pdu = DefaultPDUFactory.createPDU(snmpVersion.getTargetVersion());

ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java

@@ -888,13 +888,15 @@ public void executeQuery(String query, boolean ignoreFailure) throws SQLExceptio
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedQuery(String query, Object...arguments) throws SQLException {
     executePreparedQuery(query, false, arguments);
   }
 
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedQuery(String query, boolean ignoreFailure, Object...arguments) throws SQLException{
     LOG.info("Executing prepared query: {}", query);
 
@@ -920,13 +922,15 @@ public void executePreparedQuery(String query, boolean ignoreFailure, Object...a
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedUpdate(String query, Object...arguments) throws SQLException {
     executePreparedUpdate(query, false, arguments);
   }
 
   /**
    {@inheritDoc}
    */
+  @Override
   public void executePreparedUpdate(String query, boolean ignoreFailure, Object...arguments) throws SQLException{
     LOG.info("Executing prepared query: {}", query);
 

ambari-server/src/main/java/org/apache/ambari/server/orm/cache/HostConfigMappingImpl.java

@@ -105,6 +105,7 @@ public void setVersion(String version) {
       throw new RuntimeException("Version couldn't be null");
     this.version = version;
   }
+  @Override
   public String getServiceName() {
     return serviceName;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java

@@ -76,6 +76,7 @@ public int removeByCategory(String categoryName) {
     return query.executeUpdate();
   }
 
+  @Override
   @Transactional
   public void create(AmbariConfigurationEntity entity) {
     // make sure only one entry exists per configuration type...

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java

@@ -64,6 +64,7 @@ public class BlueprintConfigEntity implements BlueprintConfiguration {
    *
    * @return configuration type
    */
+  @Override
   public String getType() {
     return type;
   }
@@ -73,6 +74,7 @@ public String getType() {
    *
    * @param type  configuration type
    */
+  @Override
   public void setType(String type) {
     this.type = type;
   }
@@ -100,6 +102,7 @@ public void setBlueprintEntity(BlueprintEntity entity) {
    *
    * @return blueprint name
    */
+  @Override
   public String getBlueprintName() {
     return blueprintName;
   }
@@ -109,6 +112,7 @@ public String getBlueprintName() {
    * '
    * @param blueprintName  blueprint name
    */
+  @Override
   public void setBlueprintName(String blueprintName) {
     this.blueprintName = blueprintName;
   }
@@ -118,6 +122,7 @@ public void setBlueprintName(String blueprintName) {
    *
    * @return config data in json format
    */
+  @Override
   public String getConfigData() {
     return configData;
   }
@@ -127,6 +132,7 @@ public String getConfigData() {
    *
    * @param configData  all config data in json format
    */
+  @Override
   public void setConfigData(String configData) {
     this.configData = configData;
   }
@@ -136,6 +142,7 @@ public void setConfigData(String configData) {
    *
    * @return config attributes in JSON format
    */
+  @Override
   public String getConfigAttributes() {
     return configAttributes;
   }
@@ -145,6 +152,7 @@ public String getConfigAttributes() {
    *
    * @param configAttributes  all attribute values of configs in JSON format
    */
+  @Override
   public void setConfigAttributes(String configAttributes) {
     this.configAttributes = configAttributes;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java

@@ -74,6 +74,7 @@ public class HostGroupConfigEntity implements BlueprintConfiguration {
    *
    * @return configuration type
    */
+  @Override
   public String getType() {
     return type;
   }
@@ -83,6 +84,7 @@ public String getType() {
    *
    * @param type  configuration type
    */
+  @Override
   public void setType(String type) {
     this.type = type;
   }
@@ -110,6 +112,7 @@ public void setHostGroupEntity(HostGroupEntity entity) {
    *
    * @return blueprint name
    */
+  @Override
   public String getBlueprintName() {
     return blueprintName;
   }
@@ -119,6 +122,7 @@ public String getBlueprintName() {
    * '
    * @param blueprintName  blueprint name
    */
+  @Override
   public void setBlueprintName(String blueprintName) {
     this.blueprintName = blueprintName;
   }
@@ -146,6 +150,7 @@ public void setHostGroupName(String hostGroupName) {
    *
    * @return config data in json format
    */
+  @Override
   public String getConfigData() {
     return configData;
   }
@@ -155,6 +160,7 @@ public String getConfigData() {
    *
    * @param configData  all config data in json format
    */
+  @Override
   public void setConfigData(String configData) {
     this.configData = configData;
   }
@@ -164,6 +170,7 @@ public void setConfigData(String configData) {
    *
    * @return config attributes in JSON format
    */
+  @Override
   public String getConfigAttributes() {
     return configAttributes;
   }
@@ -173,6 +180,7 @@ public String getConfigAttributes() {
    *
    * @param configAttributes  all attribute values of configs in JSON format
    */
+  @Override
   public void setConfigAttributes(String configAttributes) {
     this.configAttributes = configAttributes;
   }

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/SettingEntity.java

@@ -118,6 +118,7 @@ public void setUpdateTimestamp(long updateTimestamp) {
     this.updateTimestamp = updateTimestamp;
   }
 
+  @Override
   public SettingEntity clone() {
     SettingEntity cloned = new SettingEntity();
     cloned.setId(id);