Addressing internal comments, small changes for consistency and comments

lixiaote · Mar 1, 2016 · 56abccb · 56abccb
1 parent 7e7420d
commit 56abccb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.../com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java b/.../com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java
@@ -135,6 +135,7 @@ public void orientationChange_menuAndTaskPersist() {
 
         TestUtils.rotateOrientation(mTaskDetailActivityTestRule);
 
+        // Check that the task is shown
         onView(withId(R.id.task_detail_title)).check(matches(withText(TASK_TITLE)));
         onView(withId(R.id.task_detail_description)).check(matches(withText(TASK_DESCRIPTION)));
 

diff --git a/...a/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailPresenter.java b/...a/com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailPresenter.java
@@ -64,10 +64,6 @@ public TaskDetailPresenter(@Nullable String taskId,
 
     @Override
     public void start() {
-        openTask();
-    }
-
-    private void openTask() {
         mLoaderManager.initLoader(TASK_QUERY, null, this);
     }
 

diff --git a/.../com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java b/.../com/example/android/architecture/blueprints/todoapp/taskdetail/TaskDetailScreenTest.java
@@ -135,6 +135,7 @@ public void orientationChange_menuAndTaskPersist() {
 
         TestUtils.rotateOrientation(mTaskDetailActivityTestRule);
 
+        // Check that the task is shown
         onView(withId(R.id.task_detail_title)).check(matches(withText(TASK_TITLE)));
         onView(withId(R.id.task_detail_description)).check(matches(withText(TASK_DESCRIPTION)));