Show dynamic values in "limit reached" text (#11418)

lj-michale · Feb 24, 2024 · 34348f6 · 34348f6
1 parent 7a4b017
commit 34348f6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/airbyte-webapp/src/components/connectorBuilder/StreamTestingPanel/PageDisplay.tsx b/airbyte-webapp/src/components/connectorBuilder/StreamTestingPanel/PageDisplay.tsx
@@ -39,6 +39,7 @@ export const PageDisplay: React.FC<PageDisplayProps> = ({ page, className, infer
   const {
     streamRead,
     schemaWarnings: { incompatibleSchemaErrors, schemaDifferences },
+    testReadLimits: { recordLimit, pageLimit, sliceLimit },
   } = useConnectorBuilderTestRead();
 
   const autoImportSchema = useAutoImportSchema(testStreamIndex);
@@ -54,7 +55,10 @@ export const PageDisplay: React.FC<PageDisplayProps> = ({ page, className, infer
           {`${formatMessage({ id: "connectorBuilder.recordsTab" })} (${page.records.length})`}
           {!streamRead.isFetching && streamRead.data && streamRead.data.test_read_limit_reached && (
             <InfoTooltip>
-              <FormattedMessage id="connectorBuilder.streamTestLimitReached" />
+              <FormattedMessage
+                id="connectorBuilder.streamTestLimitReached"
+                values={{ recordLimit, pageLimit, sliceLimit }}
+              />
             </InfoTooltip>
           )}
         </>

diff --git a/airbyte-webapp/src/components/connectorBuilder/StreamTestingPanel/StreamTester.tsx b/airbyte-webapp/src/components/connectorBuilder/StreamTestingPanel/StreamTester.tsx
@@ -47,6 +47,7 @@ export const StreamTester: React.FC<{
       dataUpdatedAt,
       errorUpdatedAt,
     },
+    testReadLimits: { recordLimit, pageLimit, sliceLimit },
   } = useConnectorBuilderTestRead();
   const [showLimitWarning, setShowLimitWarning] = useLocalStorage("connectorBuilderLimitWarning", true);
   const mode = useBuilderWatch("mode");
@@ -187,7 +188,12 @@ export const StreamTester: React.FC<{
       {!isFetching && streamReadData && streamReadData.test_read_limit_reached && showLimitWarning && (
         <Message
           type="warning"
-          text={<FormattedMessage id="connectorBuilder.streamTestLimitReached" />}
+          text={
+            <FormattedMessage
+              id="connectorBuilder.streamTestLimitReached"
+              values={{ recordLimit, pageLimit, sliceLimit }}
+            />
+          }
           onClose={() => {
             setShowLimitWarning(false);
           }}

diff --git a/airbyte-webapp/src/locales/en.json b/airbyte-webapp/src/locales/en.json
@@ -1169,7 +1169,7 @@
   "connectorBuilder.forkPage.prompt": "Load an existing connector",
   "connectorBuilder.loadingStreamList": "Loading",
   "connectorBuilder.noStreamSelected": "No stream selected",
-  "connectorBuilder.streamTestLimitReached": "Stream testing limit reached. During testing a maximum of 1000 records, or 5 stream partitions with 5 pages each will be returned.",
+  "connectorBuilder.streamTestLimitReached": "Stream testing limit reached. During testing a maximum of {recordLimit} records, or {sliceLimit} stream partitions with {pageLimit} pages each will be returned.",
   "connectorBuilder.builderPrompt.button": "Build your connector",
   "connectorBuilder.builderPrompt.title": "Need to build your own source?",
   "connectorBuilder.builderPrompt.description": "Build your source with our {adjective} {noun}",