[utils] Simplify check isRegExp #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 8 8
Lines 1408 1424 +16
Branches 172 173 +1
=======================================
+ Hits 1406 1422 +16
Misses 2 2
Continue to review full report at Codecov.
|
ljharb
requested changes
Jan 20, 2022
| @@ -212,7 +212,7 @@ var compact = function compact(value) { | |||
| }; | |||
|
|
|||
| var isRegExp = function isRegExp(obj) { | |||
| return Object.prototype.toString.call(obj) === '[object RegExp]'; | |||
| return obj instanceof RegExp; | |||
There was a problem hiding this comment.
unfortunately this is not short, it's broken. instanceof doesn't work across realms, and can be easily forged.
|
Please discuss changes like this in issues first, rather than sending a PR that might not be needed :-) all the "is" checks in this library are precisely what is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored
isRegExpto use short method for checking.