Skip to content

Commit

Permalink
Enable devcryptoeng for OpenSSL.
Browse files Browse the repository at this point in the history
Since OpenSSL 1.1.1, the good old BSD-specific cryptodev engine has been
deprecated in favor of this new engine.  However, this engine is not
throughly tested on FreeBSD because it was originally written for Linux.

http://cryptodev-linux.org/

Also, the author actually meant to enable it by default on BSD platforms but
he failed to do so because there was a bug in the Configure script.

openssl/openssl#7882

Now they found that it was more generic issue.

openssl/openssl#7885

Therefore, we need to enable this engine on head to give it more exposure.

(cherry picked from commit 53c4fca8e5700ed611488f3569d4705a86d3121f)
  • Loading branch information
juikim authored and rbgarga committed Oct 29, 2019
1 parent 2b5256f commit c3500d3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions secure/lib/libcrypto/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ SRCS+= ecp_nistz256-x86.S ecp_nistz256.c
.endif

# engine
SRCS+= eng_all.c eng_cnf.c eng_ctrl.c eng_dyn.c eng_err.c eng_fat.c
SRCS+= eng_init.c eng_lib.c eng_list.c eng_openssl.c eng_pkey.c
SRCS+= eng_all.c eng_cnf.c eng_ctrl.c eng_devcrypto.c eng_dyn.c eng_err.c
SRCS+= eng_fat.c eng_init.c eng_lib.c eng_list.c eng_openssl.c eng_pkey.c
SRCS+= eng_rdrand.c eng_table.c tb_asnmth.c tb_cipher.c tb_dh.c tb_digest.c
SRCS+= tb_dsa.c tb_eckey.c tb_pkmeth.c tb_rand.c tb_rsa.c

Expand Down
3 changes: 0 additions & 3 deletions secure/lib/libcrypto/opensslconf.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ extern "C" {
#ifndef OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
# define OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
#endif
#ifndef OPENSSL_NO_DEVCRYPTOENG
# define OPENSSL_NO_DEVCRYPTOENG
#endif
#ifndef OPENSSL_NO_EC_NISTP_64_GCC_128
# define OPENSSL_NO_EC_NISTP_64_GCC_128
#endif
Expand Down

0 comments on commit c3500d3

Please sign in to comment.