Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct endpoint URL in emr-hadoop-spark-jobs #111

Merged
merged 1 commit into from
May 12, 2022

Conversation

dfangl
Copy link
Contributor

@dfangl dfangl commented May 12, 2022

Currently, we use TEST_S3_URL in the sample, even though this is not possible any more.
This PR fixes this, by replacing it with the usage of LOCALSTACK_HOSTNAME and EDGE_PORT.

@dfangl dfangl requested a review from whummer May 12, 2022 15:04
Copy link
Contributor

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this fix @dfangl ! 👍

@dfangl dfangl merged commit dfa7c22 into master May 12, 2022
@dfangl dfangl deleted the fix-emr-hadoop-spark-jobs branch May 12, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants