Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix qldb ledger sample #121

Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix qldb ledger sample #121

merged 1 commit into from
Jul 4, 2022

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jul 2, 2022

Fixed the qldb sample, it was using old code from the previous version of pyqldb. Adapted the code to use the driver from 3.x.

https://docs.aws.amazon.com/qldb/latest/developerguide/driver-quickstart-python.html

@bentsku bentsku requested a review from whummer July 2, 2022 18:47
whummer
whummer approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this @bentsku ! 💯 Was able to run the sample locally with the changes in this PR 👍

@bentsku bentsku merged commit 26fbc88 into master Jul 4, 2022
@bentsku bentsku deleted the fix-qldb-sample branch July 4, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @whummer