add sample for stepfunctions using lambdas and localstack #148
Conversation
There was a problem hiding this comment.
Added some comments. I feel like this sample is generally missing a proper scenario/intent. It's not very clear what kind of process this tries to model and why that would be particularly useful for a user.
Since it's just a sample this wouldn't block a merge though 👍
| @@ -26,6 +26,7 @@ jobs: | |||
| - name: Install Dependencies | |||
| run: | | |||
| pip install virtualenv | |||
| pip install --upgrade pyopenssl | |||
There was a problem hiding this comment.
this needs to happen before installing localstack, i.e. before line 24
| localstack start -d | ||
|
|
||
| stop: | ||
| @echo |
| --input '{"adam": "LocalStack", "cole": "Stack"}' | ||
| ``` | ||
|
|
||
| This creates and invokes the flow between the three Lambda functions we created using LocalStack earlier. |
There was a problem hiding this comment.
Feels like this is missing some context about what this sample actually does and why. It's really hard to see the intent here. E.g. why is adam set to LocalStack and cole to Stack?
|
|
||
| ```sh | ||
| awslocal stepfunctions create-state-machine --name step-demo \ | ||
| --definition "$(cat step-definition.json)" \ |
There was a problem hiding this comment.
Why is this not using the same pattern as above in the Makefile? (file://....)
stepfunctions-lambda/Makefile
Outdated
| @@ -0,0 +1,69 @@ | |||
| export AWS_ACCESS_KEY_ID ?= test | |||
| export AWS_SECRET_ACCESS_KEY ?= test | |||
| export AWS_DEFAULT_REGION = us-east-1 | |||
There was a problem hiding this comment.
Do we intentionally overwrite the default region here or should it be ?= ?
There was a problem hiding this comment.
On standard template, its export AWS_DEFAULT_REGION=us-east-1
HarshCasper
force-pushed
the
step-functions
branch
from
0aadaec to
70c68ee
Compare
No description provided.