Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample for lambda event filtering with dynamodb and sqs #149

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

HarshCasper
Copy link
Member

@HarshCasper HarshCasper commented Sep 13, 2022

Description

This PR:

  • Adds sample code for lambda event filtering using AWS Lambda, SQS, DynamoDB, DynamoDB Streams.
  • Adds relevant docs to get up and running with the sample.

@HarshCasper HarshCasper requested a review from steffyP September 13, 2022 14:00
Copy link
Contributor

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example @HarshCasper 🚀 🔝

We already discussed the things that could still be improved, just summarizing it here:

  • please add a description to the PR
  • add required dependencies to the prerequites (node version, ulid lib installed)
  • add a short description on what is supposed to happen, and how it can be verified (e.g. lambda is triggered after adding sending message to the queue)

Copy link
Contributor

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀 😄 👍

@HarshCasper HarshCasper merged commit 523d21f into master Sep 19, 2022
@HarshCasper HarshCasper deleted the event-filtering-lambda branch September 19, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants