Fix broken glue-etl-jobs sample #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: We are aware of the failing Pipeline, and are investigating. Stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(No issue for this PR - it was discussed in Localstack Slack chat.)
This PR addresses the broken glue-etl-jobs sample provided in this repo. The sample should now work with Localstack Pro out of the box.
The changes included are:
CLUSTER_IDENTIFIERto use dashes (-) instead of underscores (_). Cluster identifiers do not allow underscores."$cluster_identifier"(likely a typo) toglue-etl-cluster1-connection.