Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible ML sample #202

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Reproducible ML sample #202

merged 6 commits into from
Dec 27, 2022

Conversation

giograno
Copy link
Contributor

Creating the sample we are using for our Cloud Pods tutorial (localstack/docs#399).

Copy link
Contributor

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great to see this sample added @giograno ! 🚀

Only added a minor comment/suggestion regarding the wording of running the predictions through the model - technically we're not performing model evaluation here (only running prediction for the test set). If we wanted to include model evaluation as well, we could include a classification report (which compares the actual characters vs. the predicted characters) as well, see details from the tutorial here: https://scikit-learn.org/stable/auto_examples/classification/plot_digits_classification.html#classification

print(
    f"Classification report for classifier {clf}:\n"
    f"{metrics.classification_report(y_test, predicted)}\n"
)

giograno and others added 4 commits December 27, 2022 18:23
Co-authored-by: Waldemar Hummer <[email protected]>
Co-authored-by: Waldemar Hummer <[email protected]>
Co-authored-by: Waldemar Hummer <[email protected]>
Co-authored-by: Waldemar Hummer <[email protected]>
@giograno giograno merged commit 7a467e6 into master Dec 27, 2022
@giograno giograno deleted the reproducible-ml branch December 27, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants