Add samples for using hot reloading with terraform, fix role arns #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Mar 8, 2023
| s3_key = "${abspath(path.root)}/lambda_src" | ||
| layers = [aws_lambda_layer_version.test_layer.arn] | ||
|
|
||
| runtime = "nodejs16.x" |
There was a problem hiding this comment.
I guess this wouldn't work with nodejs18.x out of the box right now?
There was a problem hiding this comment.
Probably not, due to the handler code. Not sure if ES module syntax is required for node18.
Co-authored-by: Dominik Schubert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple terraform + nodejs lambda functions to demonstrate hot-reloading.
Demonstrates
Other changes
__local__withhot-reloadin all samples, as it is the new default name.r1) in the samples with complete role arns. Using non-arns as role arns was supported for the old provider, but will not work in the new one, and we should not encourage samples with wrong default values.