Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update localstack-serverless plugin for location constraint #211

Merged
merged 3 commits into from
Mar 28, 2023
Merged

update localstack-serverless plugin for location constraint #211

merged 3 commits into from
Mar 28, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 27, 2023 •
edited
Loading

Updating serverless and localstack-serverless to get the fix about LocationConstraint.
The glue test was failing, I haven't touched it and it passed on the last run, not sure what is that about.

@bentsku bentsku requested a review from alexrashed March 27, 2023 20:58
@bentsku bentsku changed the title wip: update localstack-serverless plugin for location constraint update localstack-serverless plugin for location constraint Mar 27, 2023
alexrashed
alexrashed approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
We can take a look at the glue tests with the next runs and in another PR (if the issue remains).

@alexrashed alexrashed merged commit 60a80e0 into master Mar 28, 2023
@alexrashed alexrashed deleted the fix-serverless-plugin branch March 28, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @alexrashed