This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
refactor: tweak configuration template of the SMTP connector #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abellion thanks! would you like to follow the conventional commits to add a scope in both PR title and commit message? I think |
abellion
changed the title
|
Title changed @gao-sun ! As for the commit message, I guess if the PR is squashed when merged, it will be applied accordingly. Otherwise, the "allow edits by maintainers" checkbox is ticked :) |
gao-sun
approved these changes
Nov 6, 2022
|
@abellion we'll publish a new version soon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the default port of the SMTP server to
25(which is more common that80). It also inverts the order of thepassanduserfields, by puttinguserfirst, as it's more common to first have the username and then the password (not the other way around).Testing
N/A