Skip to content

Commit

Permalink
build: suppress errors in git hooks (angular#42484)
Browse files Browse the repository at this point in the history
When errors occur in git hooks, we can safely supress them as they are validated on CI.

This is primarily coming up as an issue related to needing to reinstall node_modules

PR Close angular#42484
  • Loading branch information
josephperrott authored and thePunderWoman committed Jun 4, 2021
1 parent a5b5136 commit 4fc24ad
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
#!/bin/sh
. "$(dirname $0)/_/husky.sh"

yarn -s ng-dev commit-message pre-commit-validate --file $1;
set +e

yarn -s ng-dev commit-message pre-commit-validate --file $1 2>/dev/null
if [ $? -ne 0 ]; then
echo "WARNING: failed to run commit message validation (ng-dev commit-mesage pre-commit-validate)"
fi

exit 0;
9 changes: 8 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
#!/bin/sh
. "$(dirname $0)/_/husky.sh"

yarn -s ng-dev format staged;
set +e
yarn -s ng-dev format staged 2>/dev/null
if [ $? -ne 0 ]; then
echo "WARNING: failed to run file formatting (ng-dev format staged)"
fi


exit 0;
9 changes: 8 additions & 1 deletion .husky/prepare-commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
#!/bin/sh
. "$(dirname $0)/_/husky.sh"

yarn -s ng-dev commit-message restore-commit-message-draft $1 $2;
set +e

yarn -s ng-dev commit-message restore-commit-message-draft $1 $2 2>/dev/null
if [ $? -ne 0 ]; then
echo "WARNING: failed to attempt to restore commit message draft (ng-dev commit-message restore-commit-message-draft)"
fi

exit 0;

0 comments on commit 4fc24ad

Please sign in to comment.